Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding mavenLocal repo to allow for local dependency override. #1852

Merged
merged 7 commits into from
Oct 17, 2022

Conversation

DavidOgunsAWS
Copy link
Contributor

@DavidOgunsAWS DavidOgunsAWS commented Oct 13, 2022

Motivation and Context

This change enables devs to test changes of upstream dependencies to checkout smithy-rs and build successfully on versions of the dependency that only exist in~/.m2/repository and not in Maven Central.

Description

Added mavenLocal() and remote repositories in multiple build.gradle.kts files

Testing

  • Built upstream dependency smithy with a modified VERSION that does not exist in repository.
  • Updated smithyVersion in gradle.properties.
  • Ran gradlew tasks to build and test code encountering errors on finding the dependency and made corrections in relevant files until build success

Checklist

  • I have updated CHANGELOG.next.toml if I made changes to the smithy-rs codegen or runtime crates
  • I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@DavidOgunsAWS DavidOgunsAWS requested review from a team as code owners October 13, 2022 19:03
@jdisanti jdisanti merged commit 9260781 into smithy-lang:main Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants