Remove the need for operation type aliasing in codegen #1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename: FluentClientGenerics.sendBounds params to be more accurate update: FlexibleClientGenerics.sendBounds impl for readability update: type of FluentClientGenerator input param `retryPolicyType` to be `Any` with a default of `RustType.Unit` update: PaginatorGenerator to take retryPolicy as an input chore: fix some spelling and grammar issues remove: redundant `nextTokenEmpty` function from PaginatorGenerator
Velfi
commented
Sep 6, 2022
.../src/main/kotlin/software/amazon/smithy/rust/codegen/smithy/generators/PaginatorGenerator.kt
Outdated
Show resolved
Hide resolved
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
reviewed
Sep 6, 2022
aws/sdk-codegen/src/main/kotlin/software/amazon/smithy/rustsdk/AwsFluentClientDecorator.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: John DiSanti <[email protected]>
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
add: test for RustType writable add: `writable` property to RuntimeType that returns the type as a Writable update: FluentClientGenerator to take a writable for retry
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
approved these changes
Sep 7, 2022
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
#976
Description
This update reorganizes codegen in a small way so that we don't need to generate confusing operation and retry policy type aliases that we hide in the docs. Because they were already
#[doc(hidden)], I chose not to mention this change in the SDK changelog.other changes:
FluentClientGenerics.sendBoundsparams to be more accurateFlexibleClientGenerics.sendBoundsimpl for readabilityFluentClientGeneratorinput paramretryPolicyTypeto beAnywith a default ofRustType.UnitPaginatorGeneratorto takeretryPolicyas an inputnextTokenEmptyfunction fromPaginatorGeneratorwritableproperty toRustTypeandRuntimeTypethat returns them inWritableformTesting
ran existing tests
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.