Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 3rd-party types from public APIs where possible #1193

Closed
26 tasks
Velfi opened this issue Feb 15, 2022 · 1 comment
Closed
26 tasks

Remove 3rd-party types from public APIs where possible #1193

Velfi opened this issue Feb 15, 2022 · 1 comment
Assignees
Labels
breaking-change This will require a breaking change client sdk-ga tracking Meta-issues to track overall progress
Milestone

Comments

@Velfi
Copy link
Contributor

Velfi commented Feb 15, 2022

There are 3rd-party types in several public APIs. Where possible

  • Newtype those types in a way that hides the inner type
  • Remove APIs that don't provide needed functionality
  • Replace types with our own
Full list of types to fix

Some of the types listed above may cease to exist as a result of future code reorganization/refactoring. We can park them for now. The ones currently actionable are tracked with the following issues:

List can be updated with:

rg -F 'TODO(https://github.com/awslabs/smithy-rs/issues/1193)' --json . | \
  jq -r 'select(.type == "match") | (.data.path.text) + "#L" + (.data.line_number | tostring)' | \
  sed 's/^\.\///g' | \
  awk -v prefix="- [ ] https://github.com/awslabs/smithy-rs/blob/$(git rev-parse HEAD)/" '{print prefix $0}' | \
  sort
@Velfi Velfi added the breaking-change This will require a breaking change label Feb 15, 2022
@jdisanti
Copy link
Collaborator

primitive::Encoder buffer types fixed in #1209

@jdisanti jdisanti added the tracking Meta-issues to track overall progress label Aug 10, 2022
@Velfi Velfi added this to the SDK GA milestone Sep 26, 2022
@jdisanti jdisanti removed their assignment Sep 30, 2022
@ysaito1001 ysaito1001 self-assigned this Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change This will require a breaking change client sdk-ga tracking Meta-issues to track overall progress
Projects
None yet
Development

No branches or pull requests

3 participants