Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Endpoint docs & aws-config spans #1087

Merged
merged 5 commits into from
Jan 25, 2022
Merged

Endpoint docs & aws-config spans #1087

merged 5 commits into from
Jan 25, 2022

Conversation

rcoh
Copy link
Collaborator

@rcoh rcoh commented Jan 19, 2022 •
edited
Loading

Motivation and Context

  • the docs on immutable / mutable were unclear
  • aws-config produced too many spans at the info level and polluted logs

Before:

run_canaries                                                                                 6s  ├─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┤
  run_canary{name: "s3"}                                                                   437ms ├──────┤
    send_operation{operation: "GetObject", service: "s3"}                                  436ms ├──────┤
  run_canary{name: "ec2_paginator"}                                                          2s  ├────────────────────────────────────┤
    send_operation{operation: "DescribeSpotPriceHistory", service: "ec2"}                  723ms ├────────────┤
      load_credentials                                                                      25μs ┆
      load_credentials                                                                     212ms ├──┤
      load_credentials                                                                     212ms ├──┤
        load_config_file                                                                   165μs ┆
        load_credentials_file                                                              694μs ┆
        load_base_credentials                                                               24μs ┆
        load_assume_role                                                                   205ms ├──┤
          send_operation{operation: "AssumeRole", service: "sts"}                          202ms ├──┤
    send_operation{operation: "DescribeSpotPriceHistory", service: "ec2"}                  355ms               ├─────┤
    send_operation{operation: "DescribeSpotPriceHistory", service: "ec2"}                  370ms                     ├─────┤
    send_operation{operation: "DescribeSpotPriceHistory", service: "ec2"}                  403ms                            ├──────┤
    send_operation{operation: "DescribeSpotPriceHistory", service: "ec2"}                   77ms                                    │
    send_operation{operation: "DescribeVpcs", service: "ec2"}                               77ms                                     │
  run_canary{name: "transcribe_canary"}                                                      6s  ├─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┤
    send_operation{operation: "StartStreamTranscription", service: "transcribestreaming"}  478ms ├───────┤

After:

run_canaries                                                                                                                7s  ├──────────────────────────────────────────────────────────────────────────────────────┤
  run_canary{name: "ec2_paginator"}                                                                                         2s  ├──────────────────────────────┤
    send_operation{operation: "DescribeSpotPriceHistory", service: "ec2", status: "ok"}                                  1205ms ├────────────┤
      provide_credentials{provider: default_chain}                                                                        257ms ├─┤
    send_operation{operation: "DescribeSpotPriceHistory", service: "ec2", status: "ok"}                                   536ms               ├────┤
      provide_credentials{provider: default_chain}                                                                         39μs               ┆
    send_operation{operation: "DescribeSpotPriceHistory", service: "ec2", status: "ok"}                                   410ms                     ├───┤
      provide_credentials{provider: default_chain}                                                                         38μs                     ┆
    send_operation{operation: "DescribeSpotPriceHistory", service: "ec2", status: "ok"}                                   409ms                          ├───┤
      provide_credentials{provider: default_chain}                                                                         43μs                          ┆
    send_operation{operation: "DescribeSpotPriceHistory", service: "ec2", status: "ok"}                                    75ms                               │
      provide_credentials{provider: default_chain}                                                                         41μs                               ┆
    send_operation{operation: "DescribeVpcs", service: "ec2", status: "ok"}                                               111ms                                │
      provide_credentials{provider: default_chain}                                                                         63μs                                ┆
  run_canary{name: "s3"}                                                                                                  480ms ├────┤
    send_operationError { code: "PermanentRedirect", message: "The bucket you are attempting to access must be addressed  479ms ├────┤
      provide_credentials{provider: default_chain}                                                                        258ms ├─┤
  run_canary{name: "transcribe_canary"}                                                                                     7s  ├──────────────────────────────────────────────────────────────────────────────────────┤
    send_operation{operation: "StartStreamTranscription", service: "transcribestreaming", status: "ok"}                  1627ms ├─────────────────┤
      provide_credentials{provider: default_chain}                                                                        256ms ├─┤
        send_operation{operation: "AssumeRole", service: "sts", status: "ok"}                                             247ms ├─┤

Description

  • improve docs on endpoint mutable / immutable
  • clean up aws-config spans so that there is a single top-level info span when loading credentials
  • add tracing-texray to the canary

Testing

  • CI

Checklist

  • I have updated CHANGELOG.next.toml if I made changes to the smithy-rs codegen or runtime crates
  • I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rcoh rcoh requested a review from a team as a code owner January 19, 2022 15:20
@github-actions
Copy link

A new doc preview is ready to view.

@github-actions
Copy link

A new generated diff is ready to view.

@github-actions
Copy link

A new doc preview is ready to view.

@github-actions
Copy link

A new generated diff is ready to view.

jdisanti
jdisanti approved these changes Jan 19, 2022
View reviewed changes
Copy link
Collaborator

@jdisanti jdisanti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Velfi
Velfi reviewed Jan 25, 2022
View reviewed changes
tools/ci-cdk/canary-lambda/src/main.rs
.with(EnvFilter::from_default_env())
.with(tracing_subscriber::fmt::layer())
.with(
TeXRayLayer::new()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rcoh You prolific author you. This is neat!

@jdisanti jdisanti enabled auto-merge (squash) January 25, 2022 20:57
@github-actions
Copy link

A new doc preview is ready to view.

@github-actions
Copy link

A new generated diff is ready to view.

@jdisanti jdisanti merged commit a411bc3 into main Jan 25, 2022
@jdisanti jdisanti deleted the endpoint-docs branch January 25, 2022 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdisanti jdisanti jdisanti approved these changes

@Velfi Velfi Velfi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rcoh @jdisanti @Velfi