New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Http Protocol bindings should not send default values #108

Closed

rcoh opened this issue Jan 13, 2021 · 1 comment · Fixed by #156

Labels

good first issue small

Milestone

Secrets Manager, ...

Collaborator

rcoh commented Jan 13, 2021

See #102 — when a queryParam (or any field) is unboxed and is a 0 value, it should not be serialized into the http request

rcoh mentioned this issue

Support optional URI elements #102

Closed

rcoh added this to the Aws Json 1.0 / 1.1 milestone

rcoh added good first issue small labels

Collaborator Author

rcoh commented Jan 13, 2021

This also needs a protocol test, I think coverage is missing

rcoh mentioned this issue

Fix generated query param serializers to omit 0-values #156

Merged

rcoh closed this as completed in #156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment