Use directed codegen #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gosar
reviewed
May 11, 2022
...hy-python-codegen/src/main/java/software/amazon/smithy/python/codegen/GenerationContext.java
Show resolved
Hide resolved
nateprewitt
reviewed
May 23, 2022
| try { | ||
| CodegenUtils.runCommand("python3 -m mypy -h", fileManifest.getBaseDir()); | ||
| } catch (CodegenException e) { | ||
| LOGGER.warning("Unable to find the python package mypy. Skipping type checking."); |
There was a problem hiding this comment.
Skipping this makes me a little leary. Do we want a way to enforce strictness on this so we don't accidentally generate code without type checking?
There was a problem hiding this comment.
This is gonna run for all our customers too, who may not care as much. It may be worth it for us to create our own temporary virtualenv, but since this is existing code that just got moved, I think that should be done in a separate pr.
There was a problem hiding this comment.
Yeah, definitely don't want it required everywhere. I was thinking more in the context of a way to opt into these being required. I'm fine handling discussion in a separate PR though.
nateprewitt
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the python generator to use the directed codegen. This reduces the amount of fiddly repetitive work we have to do.
This relies on smithy-lang/smithy#1214 to some extent since we need the topological sorting.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.