Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapter content plot shows wrong read lengths #37

Closed
shigita opened this issue Sep 2, 2022 · 1 comment
Closed

Adapter content plot shows wrong read lengths #37

shigita opened this issue Sep 2, 2022 · 1 comment

Comments

@shigita
Copy link

shigita commented Sep 2, 2022

In the version 1.0.0, the plot shows read length of 489 bp, even though the actual length is 100 bp.

image

The command, fastq file, and adapter list to reproduce this issue are as follows:

falco -a qc_adaptors_list.txt example.fq.gz

qc_adaptors_list.txt
example.fq.gz

@andrewdavidsmith
Copy link
Collaborator

@shigita This should be fixed in commit 78eac8d and I'm able to get the image with the range to 100 bp using your files and command (thanks for those!!). Be aware: adaptor enrichment can only be calculated up to 91 positions, if the smallest adapter is 10bp and the read length is 100, but the most recent commit plots all the way to 100, instead of 91, which is reasonable since the plot is cumulative. I'm closing the issue, but happy to reopen if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants