-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No results for Kmer content module in HTML and fastqc_data.txt #15
Comments
Hello, Would you be able to help me reproduce the error on my end? Specifically, could you confirm (1) if you cloned, used the release or installed from Conda thank you! |
Hello, |
So essentially the k-mer content functionality wasn't implemented at all! The data was being collected but not summarized properly. I went through the whole code and tested in your dataset. The fix on e115b55 should at least report and plot the k-mer contents, but it's not fully exactly like fastqc yet, specifically, I haven't implemented p-value calculations yet because I'll have to dig through the java BinomialDistribution package to know how to do it and it will take a little longer. That said, I think log(p-values) are a monotonic function of the obs/exp ratio. In the current implementation I am sorting k-mers by obs/exp ratio and reporting the top ones (top 20 on fastqc_data, top 10 on the plots), which in most practical cases should be identical to the ones with lowest p-values. If you use this at all in your data I'll be happy to know if this is working. EDIT: Made some changes in the code on 7426ae2 to match FastQC behavior, it's also faster because we only check for k-mers once every 50 reads, like FastQC |
Thank you! We will try 0.3.0 release. |
Falco version is 0.2.4. Kmer module turned on in configuration by changing line in limits.txt to:
Falco indicates that Kmer content FAIL, but there are no Kmer content in fastqc_data.txt:
In HTML file section not reported also:
For the same fastq file FastQC display Kmer content module as expected.
The text was updated successfully, but these errors were encountered: