Changing root still watches outside new root

[mdwhatcott]

When root is adjusted, the server still holds on to watches completely outside the new root.

I've opened an issue with fsnotify.

We may end up rolling our own "fsnotify" that works like somewhat like the python idle.py script (not sure if it would perform across lots of packages though...).

[mdwhatcott]

Looks like fsnotify has been patched by the author:

howeyc/fsnotify#71 (reference)

So, now it's a matter of updating fsnotify to see if that fixed things.

[mholt]

Excellent.

Are you still planning on using your own file system watcher/checksummer thing? That mechanism worked really well and was much simpler for our needs.

[mdwhatcott]

How we detect file changes/additions/deletions is actually just an implementation detail and really doesn't matter in the grand scheme of things. But, for the rewrite I think I'll go with the home-grown solution. As for the current version, go get -u github.com/howeyc/fsnotify will fix this issue.

[mdwhatcott]

The fix from fsnotify is good. Closing this issue.