[CAPL-264] Ensure a default timeout is provided for all outgoing requests #15644
+162
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
agparadiso
force-pushed
the
CAPL-264_ensure_timeout_on_fetch
branch
from
e191d14 to
86b3343
Compare
agparadiso
changed the title
agparadiso
force-pushed
the
CAPL-264_ensure_timeout_on_fetch
branch
from
86b3343 to
827b0d0
Compare
cedric-cordenier
previously approved these changes
Dec 12, 2024
| // TODO: handle retries | ||
| func (c *OutgoingConnectorHandler) HandleSingleNodeRequest(ctx context.Context, messageID string, req capabilities.Request) (*api.Message, error) { | ||
| // set default timeout if not provided for all outgoing requests | ||
| if req.TimeoutMs == 0 { |
There was a problem hiding this comment.
@agparadiso I know I didn't ask you to do this originally, but could we also create a subcontext with this timeout plus some margin added to it?
Atm we don't get a response from the gateway if we time out which causes some small bugs; if we add this, the context would fire on line 101 and we'd at least get a response.
cedric-cordenier
approved these changes
Dec 12, 2024
justinkaseman
approved these changes
Dec 12, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 12, 2024
…ests (#15644) * fix: ensure a default timeout is provided for all outgoing requests * chore: add a subcontext with a timeout + margin * fix: lint
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr changes the way we handle timeouts for the outgoing connector handler adding a default timeout if one is not specified.
CAPL-264
Requires
Supports