Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deployment/ccip/changeset: optional MCMS for promote candidate #15641

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

makramkd
Copy link
Contributor

Add an optional MCMS config that, when nil, will simply execute the
transactions to promote the candidate config using the deployer key.
When non-nil, it only generates the MCMS proposals.

Updated some of the validation as well and removed previous validation
that was incorrect.

Requires

Supports

Add an optional MCMS config that, when nil, will simply execute the
transactions to promote the candidate config using the deployer key.
When non-nil, it only generates the MCMS proposals.

Updated some of the validation as well and removed previous validation
that was incorrect.
Copy link
Contributor

Flakeguard Summary

Ran new or updated tests between develop and 5649294 (mk/mcms-optional-activecandidatecs).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
Test_PromoteCandidate 33.33% false false false 3 1 2 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset false 17.22s @smartcontractkit/ccip, @smartcontractkit/core
Test_PromoteCandidate/MCMS_enabled 33.33% false false false 3 1 2 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset false 9.2s @smartcontractkit/ccip, @smartcontractkit/core

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

Copy link
Contributor

github-actions bot commented Dec 11, 2024

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@makramkd makramkd marked this pull request as ready for review December 11, 2024 17:46
@makramkd makramkd requested review from a team as code owners December 11, 2024 17:46
@makramkd makramkd enabled auto-merge December 11, 2024 18:44
@makramkd makramkd added this pull request to the merge queue Dec 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 11, 2024
@makramkd makramkd added this pull request to the merge queue Dec 11, 2024
Merged via the queue into develop with commit bb66cc2 Dec 11, 2024
190 checks passed
@makramkd makramkd deleted the mk/mcms-optional-activecandidatecs branch December 11, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants