-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log workflow name with engine starting for workflow #15291
base: develop
Are you sure you want to change the base?
Conversation
I see you updated files related to
|
@@ -352,7 +352,7 @@ func (e *Engine) init(ctx context.Context) { | |||
} | |||
} | |||
|
|||
e.logger.Info("engine initialized") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e.workflow.name is hex-encoded just fyi -- do you want to log the human readable version instead? (Accessible via cfg.WorkflowName)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! Thanks for catching that
AER Report: CI Coreaer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , Flakeguard Root Project / Get Tests To Run , lint , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_race_tests) , Flakeguard Deployment Project , Core Tests (go_core_fuzz) , Flakeguard Root Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/services/workflows, ubuntu-latest) , Flakey Test Detection , SonarQube Scan , Flakeguard Root Project / Report 1. Undefined field or method
|
5fa4d9b
to
2c14289
Compare
Makes it easier to match which workflowID relates to which workflow via logs