Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log workflow name with engine starting for workflow #15291

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

justinkaseman
Copy link
Contributor

@justinkaseman justinkaseman commented Nov 18, 2024

Makes it easier to match which workflowID relates to which workflow via logs

@justinkaseman justinkaseman requested a review from a team as a code owner November 18, 2024 19:22
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@justinkaseman justinkaseman requested a review from a team November 26, 2024 16:38
MStreet3
MStreet3 previously approved these changes Nov 27, 2024
@@ -352,7 +352,7 @@ func (e *Engine) init(ctx context.Context) {
}
}

e.logger.Info("engine initialized")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e.workflow.name is hex-encoded just fyi -- do you want to log the human readable version instead? (Accessible via cfg.WorkflowName)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Thanks for catching that

Copy link
Contributor

github-actions bot commented Nov 29, 2024

AER Report: CI Core

aer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , Flakeguard Root Project / Get Tests To Run , lint , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_race_tests) , Flakeguard Deployment Project , Core Tests (go_core_fuzz) , Flakeguard Root Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/services/workflows, ubuntu-latest) , Flakey Test Detection , SonarQube Scan , Flakeguard Root Project / Report

1. Undefined field or method name in workflow type: go_core_race_tests

Source of Error:
# github.com/smartcontractkit/chainlink/v2/core/services/workflows
core/services/workflows/engine.go:355:46: (*e.workflow).name undefined (type workflow has no field or method name)
**Why**: The error occurs because the `workflow` type does not have a field or method named `name`. This could be due to a typo, a missing field in the struct definition, or an incorrect method call.

Suggested fix: Verify the workflow struct definition and ensure it includes a name field or method. If it should be a method, ensure it is correctly defined and accessible.

2. Undefined field or method name in workflow type: go_core_tests_integration

Source of Error:
# github.com/smartcontractkit/chainlink/v2/core/services/workflows
core/services/workflows/engine.go:355:46: (*e.workflow).name undefined (type workflow has no field or method name)
**Why**: The error occurs because the `workflow` type does not have a field or method named `name`. This could be due to a typo, a missing field in the struct definition, or an incorrect method call.

Suggested fix: Verify the workflow struct definition and ensure it includes a name field or method. If it should be a method, ensure it is correctly defined and accessible.

3. Undefined field or method name in workflow type: go_core_ccip_deployment_tests

Source of Error:
# github.com/smartcontractkit/chainlink/v2/core/services/workflows
core/services/workflows/engine.go:355:46: (*e.workflow).name undefined (type workflow has no field or method name)
**Why**: The error occurs because the `workflow` type does not have a field or method named `name`. This could be due to a typo, a missing field in the struct definition, or an incorrect method call.

Suggested fix: Verify the workflow struct definition and ensure it includes a name field or method. If it should be a method, ensure it is correctly defined and accessible.

4. Undefined field or method name in workflow type: Golang Lint

Source of Error:
# github.com/smartcontractkit/chainlink/v2/core/services/workflows
core/services/workflows/engine.go:355:46: (*e.workflow).name undefined (type workflow has no field or method name)
**Why**: The error occurs because the `workflow` type does not have a field or method named `name`. This could be due to a typo, a missing field in the struct definition, or an incorrect method call.

Suggested fix: Verify the workflow struct definition and ensure it includes a name field or method. If it should be a method, ensure it is correctly defined and accessible.

5. Undefined field or method name in workflow type: go_core_fuzz

Source of Error:
# github.com/smartcontractkit/chainlink/v2/core/services/workflows
core/services/workflows/engine.go:355:46: (*e.workflow).name undefined (type workflow has no field or method name)
**Why**: The error occurs because the `workflow` type does not have a field or method named `name`. This could be due to a typo, a missing field in the struct definition, or an incorrect method call.

Suggested fix: Verify the workflow struct definition and ensure it includes a name field or method. If it should be a method, ensure it is correctly defined and accessible.

6. Undefined field or method name in workflow type: go_core_tests

Source of Error:
# github.com/smartcontractkit/chainlink/v2/core/services/workflows
core/services/workflows/engine.go:355:46: (*e.workflow).name undefined (type workflow has no field or method name)
**Why**: The error occurs because the `workflow` type does not have a field or method named `name`. This could be due to a typo, a missing field in the struct definition, or an incorrect method call.

Suggested fix: Verify the workflow struct definition and ensure it includes a name field or method. If it should be a method, ensure it is correctly defined and accessible.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants