Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit names to all CI workflow checks + tweak branch protection rules #267

Closed
krebernisak opened this issue Mar 25, 2022 · 1 comment

Comments

@krebernisak
Copy link
Collaborator

krebernisak commented Mar 25, 2022

Some checks like lint, test, build (ubuntu-latest, 14.x) & format (ubuntu-latest, 14.x) were removed from branch protection rules as they were not setup properly and blocked some PRs:

Notice: there are no names for defined checks so it's hard to figure out what checks do those names actually reference.

Action items:

  • Add explicit names to all CI workflow checks so they are easily identifiable
  • Check, tweak & improve on: workflow triggers in the context of branch protection rules
  • Reconfigure branch protection rules as appropriate, considering both develop & main branches
@krebernisak krebernisak changed the title Add proper names to all CI workflow checks + tweak branch protection rules Add explicit names to all CI workflow checks + tweak branch protection rules Mar 25, 2022
@tateexon
Copy link
Contributor

Changes pushed in #256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants