Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some code quality ideas #331

Open
arvidj opened this issue Nov 3, 2021 · 3 comments
Open

Some code quality ideas #331

arvidj opened this issue Nov 3, 2021 · 3 comments

Comments

@arvidj
Copy link

arvidj commented Nov 3, 2021

I'm wondering what your general feeling would be about:

  • Using poetry for dependency management for those not using nix.
  • Using a code formatter like black.
  • Using typehints and typechecker like mypy. I've experimented using pyannotate to annotate tests/gitlab_api_mock.py (it required a fair deal of manual annotation though) and found the resulting file far easier to understand.
@JohnVillalovos
Copy link

#291 Has some poetry work going on there.

@arvidj
Copy link
Author

arvidj commented Feb 10, 2022

FYI, black is now stable , and is used by e.g. Drupal.

@nejch
Copy link
Contributor

nejch commented Feb 10, 2022

I guess all of this is also related to #295, as there's more quality of life stuff for developers discussed there, but there's a bit of a backlog already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants