Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register component before mounting #688

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Conversation

carvinlo
Copy link
Contributor

@carvinlo carvinlo commented Apr 15, 2024

New Pull Request

For more information, see the CONTRIBUTING guide.

Prerequisites

Please make sure you can check the following boxes:

  • I have read the CONTRIBUTING document
  • My code follows the code style of this project
  • All new and existing tests passed

Type(s) of Changes

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue, please reference the issue id)
  • New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have updated the documentation accordingly
  • I have added tests to cover my changes

Description

Error reported in nested extension component:
image
here is MWE
Steps to Reproduce: yarn && cd src/samples/sample-piral-core && yarn start

Remarks

Register component before mounting

@carvinlo carvinlo changed the title Register plugins before mounting Register component before mounting Apr 15, 2024
Copy link

File size impact

Merging patch-3 into develop impact files as follow:

empty-piral (no impact)
Files new size
Unmodified (2) 30.2 kB (0 B / +0%) 👻
Total (2) 30.2 kB (0 B / +0%) 👻
minimal-piral (no impact)
Files new size
Unmodified (2) 277 kB (0 B / +0%) 👻
Total (2) 277 kB (0 B / +0%) 👻
sample-cross-fx (no impact)
Files new size
Unmodified (3) 2.22 MB (0 B / +0%) 👻
Total (3) 2.22 MB (0 B / +0%) 👻
sample-piral (no impact)
Files new size
Unmodified (3) 696 kB (0 B / +0%) 👻
Total (3) 696 kB (0 B / +0%) 👻
sample-piral-core (no impact)
Files new size
Unmodified (3) 354 kB (0 B / +0%) 👻
Total (3) 354 kB (0 B / +0%) 👻
Generated by @jsenv/file-size-impact during check-bundle-size#8689837775 on 61f3d81

Copy link
Contributor

@FlorianRappl FlorianRappl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@FlorianRappl FlorianRappl added vue Concerns the vue integration piral-vue. converter Concerns with a potential representation converter. labels Apr 15, 2024
@FlorianRappl FlorianRappl added this to the 1.5.4 milestone Apr 15, 2024
@FlorianRappl FlorianRappl merged commit 882a018 into smapiot:develop Apr 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
converter Concerns with a potential representation converter. vue Concerns the vue integration piral-vue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants