registerPage: No converter for component of type "function ConnectFunction(props) {...

[SantoJambit]

Bug Report

Prerequisites

• Can you reproduce the problem in a MWE?
• Are you running the latest version?
• Did you perform a search in the issues?

Environment Details and Version

Piral 0.8.0

Description

calling registerPage with a component returned by react-redux's connect() method, I'm getting an exception:

No converter for component of type "function ConnectFunction(props) {...

Steps to Reproduce

1. create a component using connect() of the react-redux package.
2. Pass that component to app.registerPage()
3. Notice it throwing an error.

Expected behavior

I expect this to work with react-redux components.

Actual behavior

An exception is thrown

Possible Origin

At this point, you are trying to use component.type:

piral/src/packages/piral-core/src/utils/components.ts

Line 16 in 57dd5af

const converter = converters[component.type];

But component.type is not a string, but instead is a function for this connected component.

[FlorianRappl]

I'm confused. Every React component (I'm aware of) must be a function (either a class component or a FC).

Can you show the MWE? I tried, e.g., a class component and everything works without a flaw.

Just to be clear - if your code ends up in this part, you'd put in an object (as in typeof foo === 'object'). Glancing over react-redux I've also not seen an object returned, just (wrapped) functions. Maybe I'm missing something though.

[SantoJambit]

Here you go: https://github.com/SantoJambit/piral-mwe

[SantoJambit]

I've taken a deeper look and I think the issue comes with React.memo. I've updated the MWE to use React.memo instead of react-redux to reproduce the issue.

[SantoJambit]

Other react higher order components return objects as well: React.lazy, react.forwardRef.

The common part seems to be that an attribute $$typeof is present, with a value of Symbol(react.memo), Symbol(react.forward_ref), etc. respectively

[FlorianRappl]

I see, thanks for figuring out a way to reproduce this. I think we can deal with the $$typeof special prop for the moment.

According to the type definitions we have:

    interface ExoticComponent<P = {}> {
        /**
         * **NOTE**: Exotic components are not callable.
         */
        (props: P): (ReactElement|null);
        readonly $$typeof: symbol;
    }

So looking if $$typeof is there and a symbol could be sufficient.

Hotfix with 0.8.1 incoming later today / tomorrow morning.

Thanks for the report! 🍻

[FlorianRappl]

Landed in develop.