Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue 3 Reactivity is Broken #720

Closed
3 tasks done
FlorianRappl opened this issue Oct 12, 2024 · 1 comment
Closed
3 tasks done

Vue 3 Reactivity is Broken #720

FlorianRappl opened this issue Oct 12, 2024 · 1 comment
Labels
bug Something isn't working converter Concerns with a potential representation converter. vue Concerns the vue integration piral-vue.
Milestone

Comments

@FlorianRappl
Copy link
Contributor

Bug Report

For more information, see the CONTRIBUTING guide.

Prerequisites

  • Can you reproduce the problem in a MWE?
  • Are you running the latest version?
  • Did you perform a search in the issues?

Environment Details and Version

Latest version.

Description

I'm using Vue in pilets and can't make Piral extension params to be reactive, eg. "loading" prop in "params" always has only initial value and it's not reflecting changes. Any idea how to fix it? 🙂

Thanks to Adam Chwilkowski for discovering the bug and providing the MWE!

Steps to Reproduce

  1. Clone the MWE
  2. Install and build the shell
  3. Install and start the pilet
  4. Click the button / toggle the state

https://gitlab.com/achwilko/mwe-piral-cli-vue/-/tree/chore/piral-extension-reactive-props?ref_type=heads

image

Expected behavior

The prop / value changes.

Actual behavior

Nothing changes.

Possible Origin/Solution

Not properly changing the forwarded props.

Is this also an issue in Vue 2? Maybe the same / a similar fix would be good here, too.

@FlorianRappl FlorianRappl added bug Something isn't working vue Concerns the vue integration piral-vue. converter Concerns with a potential representation converter. in-review The item is currently being reviewed. labels Oct 12, 2024
@FlorianRappl FlorianRappl added this to the 1.7.0 milestone Oct 12, 2024
FlorianRappl added a commit that referenced this issue Oct 12, 2024
@FlorianRappl FlorianRappl added in-testing The item is already out in preview and can be tested. and removed in-review The item is currently being reviewed. in-testing The item is already out in preview and can be tested. labels Oct 12, 2024
@FlorianRappl
Copy link
Contributor Author

Part of 1.7.0 (currently in preview / next tag).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working converter Concerns with a potential representation converter. vue Concerns the vue integration piral-vue.
Projects
None yet
Development

No branches or pull requests

1 participant