Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.krasrc resolution from process.cwd() folder #691

Closed
yasithA opened this issue Apr 18, 2024 · 5 comments
Closed

.krasrc resolution from process.cwd() folder #691

yasithA opened this issue Apr 18, 2024 · 5 comments
Labels
cli Concerns the piral-cli application. enhancement New feature or request
Milestone

Comments

@yasithA
Copy link

yasithA commented Apr 18, 2024

New Feature Proposal

Description

In a monorepo setup, it is likely to have a .krasrc file in the project root which applies some config to all pilet projects in the monorepo (i.e. setting the host as ::) so only one time configuration is enough.

At the moment, this must be explicitly given with the --krasrc flag.

Would be nice if a .krasrc file from the process.cwd() directory can be taken by default.

Background

https://discord.com/channels/1222632475449229352/1230487821677101057

@yasithA yasithA added the enhancement New feature or request label Apr 18, 2024
@FlorianRappl FlorianRappl added this to the 1.5.4 milestone Apr 18, 2024
@FlorianRappl FlorianRappl added cli Concerns the piral-cli application. in-review The item is currently being reviewed. in-implementation The item is currently being implemented. and removed in-review The item is currently being reviewed. labels Apr 18, 2024
@FlorianRappl
Copy link
Contributor

I've pushed an update to the piral-cli, which includes the code to consider the current working directory krasrc file, too.

Will be part of the next preview package.

@FlorianRappl FlorianRappl added in-testing The item is already out in preview and can be tested. and removed in-implementation The item is currently being implemented. labels Apr 19, 2024
@FlorianRappl
Copy link
Contributor

Quick question @yasithA - have you tried the preview version? Does it work for you?

@yasithA
Copy link
Author

yasithA commented Apr 19, 2024

@FlorianRappl I did not yet. Please give me around an hour, will test it and let you know. Is this is the version I should take?
1.5.4-beta.7016

@yasithA
Copy link
Author

yasithA commented Apr 19, 2024

@FlorianRappl Just tested. Working as expected. :) Thanks a lot 🎉

@FlorianRappl
Copy link
Contributor

Awesome - thanks for the feedback!

@FlorianRappl FlorianRappl removed the in-testing The item is already out in preview and can be tested. label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Concerns the piral-cli application. enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants