Repeat to connect to the server

[carvinlo]

Bug Report

For more information, see the CONTRIBUTING guide.

Prerequisites

• Can you reproduce the problem in a MWE?
• Are you running the latest version?
• Did you perform a search in the issues?

Environment Details and Version

macos
[email protected]

Description

Repeat to connect to the server

Steps to Reproduce

MWE

1. yarn && cd src/samples/sample-piral-core && yarn start
2. Modify any content of the file src/samples/sample-piral-core/package.json and commit to the staging area
   

Expected behavior

Do not restart the server repeatedly

Actual behavior

Repeatedly restart the server

Possible Origin/Solution

The content of the files package.json/.krasrc monitored by fs.watch has not changed, and the server has been restarted.

[FlorianRappl]

The content of the files package.json/.krasrc monitored by fs.watch has not changed, and the server has been restarted.

I don't understand this - the repro steps listen explicitly that the package.json should be modified - so yes, with such a modification the server should restart.

I'll have a look with the repro steps, but a server restart is expected if certain files changed (otherwise you'd need to manually shut down the server and restart it again).

[FlorianRappl]

Alright, so as this is an edge case (package.json changed, leading to a change for the dev server) we'll exclude it. This implies that changes to the package.json that affect the build (e.g., change of the "app" path) would require a fixed restart. I guess this is a good trade-off, as such scenarios rarely occur and often are expected to come with a manual server restart anyway.

The server would still restart on changes to the krasrc; as it might re-configure the server in crucial areas.

[carvinlo]

The server would restart multiple times on changes to the krasrc.
version: 1.5.4-beta.6998

[FlorianRappl]

Hm these two are not connected; also I have not seen this myself. I guess we can close it unless you can come up with a reproducible.

[carvinlo]

The server would restart multiple times on changes to the krasrc. version: 1.5.4-beta.6998

This is also an edge case. This happens when app-shell's webpack.config.js configures a longer build.
But it no longer affects normal development. Thanks for the quick fix.