Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pilet Scaffolding: configurable destination path for copying files from Piral instance #58

Closed
lschoett opened this issue Aug 19, 2019 · 4 comments
Labels
cli Concerns the piral-cli application. enhancement New feature or request
Milestone

Comments

@lschoett
Copy link
Contributor

lschoett commented Aug 19, 2019

Description

For the Pilet scaffolding files can be added to the Piral instance and referenced in the package.json file. The files will be copied as part of the scaffolding process to the same destination path as the are located in the Piral instance.

The scaffolding process should support that the destination for the files in the new Pilet can be configured.

Background

This enhancement would add further flexibility in customising the scaffolding of Pilets based on the Piral instance.

@lschoett lschoett added the enhancement New feature or request label Aug 19, 2019
@FlorianRappl FlorianRappl added the cli Concerns the piral-cli application. label Aug 19, 2019
@FlorianRappl
Copy link
Contributor

The approach that was discussed earlier would be to allow either

  • Simple strings (relative path from source in Piral instance root, will be relative path to target in Pilet root), or
  • Objects using { from: string, to: string } format, where both parts can be specified independently

in the files part of the pilets section in the package.json of the respective Piral instance.

Any other ideas or comments?

@FlorianRappl FlorianRappl added this to the 0.7.0 milestone Aug 19, 2019
@lschoett
Copy link
Contributor Author

My suggestion would be to use the second approach with the object. This will give more flexibility for the scaffolding and the files for the Pilets can be separated into a dedicated "scaffolding" folder within the Piral instance.

@FlorianRappl
Copy link
Contributor

My suggestion would be to use the second approach with the object. This will give more flexibility for the scaffolding and the files for the Pilets can be separated into a dedicated "scaffolding" folder within the Piral instance.

Sorry my bad. In the sentence above either mean that both approaches can be used (the plain string is the current one, so the object would be an added alternative).

If you would opt in for exclusively the object I have my doubts due to

  • breaking change in a config file (very bad)
  • too verbose for direct copies (currently supported scenario)

@FlorianRappl
Copy link
Contributor

FlorianRappl commented Aug 26, 2019

Landed in develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Concerns the piral-cli application. enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants