Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event listener is not removed #129

Closed
prepfarm opened this issue Dec 11, 2023 · 4 comments
Closed

Event listener is not removed #129

prepfarm opened this issue Dec 11, 2023 · 4 comments
Labels
blazor-v7 Applied to .NET 7.0 bug Something isn't working core Handled in Piral.Blazor.Core
Milestone
v10

Comments

@prepfarm
Copy link
Contributor

Bug Report

Prerequisites

  • [ x] Can you reproduce the problem in a MWE?
  • [ x] Are you running the latest version?
  • [x ] Did you perform a search in the issues?

Environment Details and Version

piral 1.3.3
net7.0 with Piral.Blazor packages are 7.0.10-pre.20231128.2

Description

RemoveEventListener Is not actually removing event listener. Trying out this example inside of my project, is not getting removed and if component gets initialized again (go back and open the page again), number of logs always increases by one (I have added log inside of the ToggleSidebar method).

Expected behavior

Event listener to be removed.
@prepfarm prepfarm added the bug Something isn't working label Dec 11, 2023
@FlorianRappl FlorianRappl added this to the v10 milestone Dec 11, 2023
@FlorianRappl
Copy link
Collaborator

Are you sure that the dispose is called?

@prepfarm
Copy link
Contributor Author

Yes, I have added @implements IDisposable and log inside of Dispose method which gets called few seconds after navigating off that page.

@FlorianRappl
Copy link
Collaborator

Alright thanks for the confirmation - I will look into it.

@FlorianRappl FlorianRappl added the in-review Currently being reviewed label Dec 11, 2023
@FlorianRappl FlorianRappl added in-testing Currently in preview / being tested. blazor-v7 Applied to .NET 7.0 core Handled in Piral.Blazor.Core and removed in-review Currently being reviewed labels Dec 21, 2023
FlorianRappl added a commit that referenced this issue Dec 22, 2023
@FlorianRappl
Fixed issue with handlers not being removed #129
fdc0d20
@FlorianRappl
Copy link
Collaborator

This is fixed and will be part of v10.

@FlorianRappl FlorianRappl removed the in-testing Currently in preview / being tested. label Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blazor-v7 Applied to .NET 7.0 bug Something isn't working core Handled in Piral.Blazor.Core
Projects
None yet
Milestone
v10
Development

No branches or pull requests
2 participants
@FlorianRappl @prepfarm