Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boost program_options shared_ptr instead of raw pointer #323

Closed
smanders opened this issue Jul 13, 2021 · 4 comments
Closed

boost program_options shared_ptr instead of raw pointer #323

smanders opened this issue Jul 13, 2021 · 4 comments
Assignees
Milestone

Comments

@smanders
Copy link
Owner

boost 1.67.0 patch externpro/program_options#1
boost 1.76.0 patch externpro/program_options#2
see boostorg/program_options#109 for details

@smanders smanders added this to the 21.04 milestone Jul 13, 2021
@smanders smanders self-assigned this Jul 13, 2021
@smanders
Copy link
Owner Author

the patch includes both changes to cpp and hpp files, which is different than any of our existing boost patches (all header-only)

so I'll have to see if there is anything different I need to do with SUBDIR and PATCH_STRIP...

SUBDIR . # since the patch is all headers, apply to root of boost, not libs/asio

PATCH_STRIP 2 # Strip NUM leading components from file names (defaults to 1)

I was pretty sure we'd patched a boost library before that contained both cpp and hpp files, so I went looking through the history -- and it appears we did for boost::iostreams and I broke it out into two patches

but I didn't ever commit the externpro project files that used these patches as it turned out they weren't needed for the "build boost with zlib support" feature

@smanders
Copy link
Owner Author

the include/ changes have to be in a separate patch from the src/ and test/ changes because the patches are applied to the boost tar.bz2

  • include/boost/program_options/ changes need to be applied to boost/program_options in the root
    • SUBDIR . and PATCH_STRIP 2
  • src/ and test/ changes need to be applied to libs/program_options/
    • SUBDIR ./libs/program_options/ and PATCH_STRIP 1

smanders pushed a commit that referenced this issue Jul 13, 2021
@smanders
Copy link
Owner Author

@smanders
Copy link
Owner Author

completed with commit referenced above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant