Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the AssertSubscriber items list back to copyOnWrite #1386

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

ozangunalp
Copy link
Collaborator

This changes the AssertSubscriber items list back tyo CopyOnWriteArrayList.

The synchronized list is not very practical to write assertions with concurrent access to the list. It requires that the list access is also synchronized on the list.

@ozangunalp ozangunalp force-pushed the assert_subscriber_list branch from f8969c0 to 60fa0f1 Compare September 27, 2023 08:58
@ozangunalp ozangunalp force-pushed the assert_subscriber_list branch from 60fa0f1 to 5442f2c Compare September 27, 2023 10:09
Copy link
Member

@jponge jponge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge, but you'll need to fix the commit message to something like:

fix: change the AssertSubscriber items list back to CopyOnWriteArrayList

@jponge
Copy link
Member

jponge commented Sep 27, 2023

Do you need a fast-tracked patch release for Reactive Messaging?

@jponge jponge added this to the 2.6.0 milestone Sep 27, 2023
@jponge jponge enabled auto-merge September 27, 2023 10:24
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #1386 (3ec4341) into main (477b3fc) will increase coverage by 0.05%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head 3ec4341 differs from pull request most recent head 5442f2c. Consider uploading reports for the commit 5442f2c to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1386      +/-   ##
============================================
+ Coverage     89.19%   89.24%   +0.05%     
- Complexity     3361     3364       +3     
============================================
  Files           459      459              
  Lines         13438    13438              
  Branches       1655     1655              
============================================
+ Hits          11986    11993       +7     
+ Misses          806      803       -3     
+ Partials        646      642       -4     
Files Coverage Δ
...smallrye/mutiny/helpers/test/AssertSubscriber.java 91.91% <100.00%> (ø)

... and 9 files with indirect coverage changes

@jponge jponge merged commit 50184ca into smallrye:main Sep 27, 2023
@ozangunalp ozangunalp deleted the assert_subscriber_list branch September 27, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants