-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add our own @Deprecated annotation + directive #1736
Comments
It would be cool to extend or implement java.lang.Deprecated as well so that IDEs see the field as deprecated. However, I understand the flexibility of having both options can be benefitial. On the other hand, if someone wants both do we really want the below?
Perhaps we give it a slightly different name like @Gql_Deprecated? |
I'd also rather reuse the existing |
|
My main point is we want to have an annotation with an API that exactly matches the API of the directive mentioned in the GraphQL spec. |
Fair point. It's just ugly to have several annotations on your classpath triggering different behaviour. Supporting both would be the best compromise, I guess. |
Add a
@io.smallrye.graphql.api.Deprecated
annotation that has an optionalString reason
parameter and is transformed into the schema as a directive.The directive should look the same as described in https://spec.graphql.org/draft/#sec--deprecated
This can be a task for @mskacelik
The text was updated successfully, but these errors were encountered: