Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] e2e tests for #3083 #3086

Closed
laurentsimon opened this issue Jan 16, 2024 · 6 comments
Closed

[feature] e2e tests for #3083 #3086

laurentsimon opened this issue Jan 16, 2024 · 6 comments

Comments

@laurentsimon
Copy link
Collaborator

Need to close the loop and add e2e2 tests for #3083

@laurentsimon
Copy link
Collaborator Author

/cc @ramonpetgrave64

@pandaninjas
Copy link
Contributor

My PR might not work just yet: see https://github.com/thefightagainstmalware/NoSession/actions/runs/7545330082/job/20540724782.
This issue might not just be moving the same file from source to destination, it might also be moving a parent directory into a child (or vice versa)

@laurentsimon
Copy link
Collaborator Author

laurentsimon commented Jan 16, 2024

I'll see if the e2e tests fail. If they do, I'll revert :)

@pandaninjas
Copy link
Contributor

I'll see if the e2e tests fail. If they do, I'll revert :)

The e2e test probably won't fail, but the PR doesn't do what it set out to accomplish.

@laurentsimon
Copy link
Collaborator Author

ah you're right! Let me revert now then

@laurentsimon
Copy link
Collaborator Author

I think this is fixed. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants