Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index is not a valid table key type? #342

Closed
isaacrlee opened this issue Jul 26, 2024 · 4 comments
Closed

index is not a valid table key type? #342

isaacrlee opened this issue Jul 26, 2024 · 4 comments

Comments

@isaacrlee
Copy link

Issue Description

  • Description of the issue:

    • index does not seem like a valid type for table_keys. I think it might be missing here? I found the table_keys feature through this issue where index is an example.
  • Sling version (sling --version): I am using 1.1.5, but I don't think there have been changes since the table keys feature was added in 1.1.4.

  • Operating System (linux, mac, windows): Windows

  • Replication Configuration:
    I am using a dictionary for config through integration with Dagster but the relevant config is:

 "target_options": {
      "table_keys": {
          "index": ["column_to_index"],
      },
  }
  • Log Output (please run command with -d):
index is not a valid table key type. Valid table key types are: "aggregate","cluster","duplicate","hash","partition","primary","sort","unique","update"
@flarco
Copy link
Collaborator

flarco commented Jul 27, 2024

Hi, first thing, you are using an ancient version of sling. Would be good to upgrade for more features and stability.
Second, you are right, the index is actually missing for the list here: https://github.com/slingdata-io/sling-cli/blob/main/core/dbio/iop/datatype.go#L85
This will be added in the next release, however in the issue (#149 (comment)) you've linked, this was an example of what the future would look like. Those don't work yet.
There is this outstanding issue open for that work: #226

@isaacrlee
Copy link
Author

Thanks for the response, apologies, was skimming through issues and missed the part about it being planned. Feel free to close this as a duplicate of 226.

@flarco
Copy link
Collaborator

flarco commented Jul 27, 2024

No worries, I'll add indexes for next release, actually not a huge lift.

@flarco
Copy link
Collaborator

flarco commented Jul 27, 2024

Fixed in #344

@flarco flarco closed this as completed Jul 27, 2024
@flarco flarco mentioned this issue Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants