Add ability to delete messages #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| @_client.logger.debug "Sending message delete request" | ||
| @_client.logger.debug params | ||
| if @ts then @_client._apiCall "chat.delete", params, @_onDeleteMessage |
There was a problem hiding this comment.
If the request is going to be conditionally sent I think the logging should go in the same conditional.
There was a problem hiding this comment.
Good point, fixed in bdfb0fa
paulhammond
added a commit
that referenced
this pull request
Feb 3, 2015
Add ability to delete messages
aoberoi
added a commit
to aoberoi/node-slack-sdk
that referenced
this pull request
Mar 20, 2019
reformat blog link
aoberoi
added a commit
to aoberoi/node-slack-sdk
that referenced
this pull request
Mar 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests builds on the pattern from #14, and adds the ability to delete messages.