Fix static host map wrong responder situations, correct logging #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects a situation where you change the overlay address at a static host endpoint.
Starting config:
Change the vpn addr serviced at
0.0.0.1:4242(replaced your lighthouse with a new overlay addr but reused the underlay addr)nebulastill knows about the first config"192.168.1.1": ["0.0.0.1:4242"]. Ifnebulais asked to talk to192.168.1.1it will handshake with0.0.0.1:4242who is now192.168.1.2.The issue was we were unable to block the underlay addresses provided by the statis host map so nebula would rapidly re handshake with the same bad host.
This also corrects the blocked udp addrs log line and finishes forming the bad tunnel so we can close it correctly.