Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot read property 'tapAsync' of undefined when using with HTML Webpack Plugin 4.0.0-alpha.2 #20

Closed
4 of 9 tasks
ajaybc opened this issue Oct 9, 2018 · 4 comments
Closed
4 of 9 tasks

Comments

@ajaybc
Copy link

ajaybc commented Oct 9, 2018

Description

I used the latest create-react-app CLI to bootstrap my project and then I ejected it. The latest create-react-app uses "html-webpack-plugin" version 4.0.0-alpha.2. When I use "csp-html-webpack-plugin" with it I am getting the following error

Cannot read property 'tapAsync' of undefined

I have already tried placing "csp-html-webpack-plugin" at the end of the plugins list after "html-webpack-plugin" and still I am getting the same issue.

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.

Bug Report

Filling out the following details about bugs will help us solve your issue sooner.

Reproducible in:

slackhq/csp-html-webpack-plugin version: 2.3.0

node version: 8.12.0

OS version(s): OSX Mojave

Steps to reproduce:

  1. Bootstrap an app with the latest create-react-app CLI
  2. Eject the application
  3. Then try using "csp-html-webpack-plugin"

Expected result:

Expected the build to complete

Actual result:

Got the error "Cannot read property 'tapAsync' of undefined"

@AnujRNair
Copy link
Contributor

Thanks for reporting!

We have PR #16 in flight which will include webpack 4 support and fix this error :)

@ajaybc
Copy link
Author

ajaybc commented Oct 10, 2018

@AnujRNair Thanks for the reply. Can we have a beta version of the "csp-html-webpack-plugin" with the support. Pretty please :)

@sibiraj-s
Copy link
Contributor

sibiraj-s commented Oct 15, 2018

@ajaybc html-webpack-plugin final version will be available by the end of this month. and @AnujRNair
clearly stated here #16 (comment)

but won't actually merge until HTMLWebpackPlugin comes out of alpha and beta, just incase there are unforseen API updates

he is waiting for the final release. So you may have to wait 10 more days.

Also @AnujRNair. I am pretty sure, that there will be no api changes to the plugin. based on jantimon/html-webpack-plugin#953 (comment)

@AnujRNair
Copy link
Contributor

HtmlWebpackPlugin 4 functionality has been merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants