From 4e9c7a7e74b0aa5e6bdbe452a6f0ebbacf1fbc55 Mon Sep 17 00:00:00 2001 From: Fil Maj Date: Fri, 19 Jul 2024 09:06:50 -0400 Subject: [PATCH] ci: lock to node 22.4.x when running on node 22; fixes npm issues w/ node 22.5.x (#1847) --- .github/workflows/ci-build.yml | 5 +++-- package.json | 4 ++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci-build.yml b/.github/workflows/ci-build.yml index bcf34cdad..117875432 100644 --- a/.github/workflows/ci-build.yml +++ b/.github/workflows/ci-build.yml @@ -13,7 +13,7 @@ jobs: strategy: fail-fast: false matrix: - node-version: [18.x, 20.x, 22.x] + node-version: [18.x, 20.x, 22.4.x] package: - cli-hooks - cli-test @@ -30,12 +30,13 @@ jobs: uses: actions/setup-node@v4 with: node-version: ${{ matrix.node-version }} + - run: npm --version - name: Get Development Dependencies run: npm i - name: Build and Run Tests in Each Package working-directory: packages/${{ matrix.package }} run: | - npm install || npm list + npm install # depending on which package we are testing, also npm link up other dependent packages case "$PWD" in */webhook) pushd ../types && npm i && popd && npm link ../types;; diff --git a/package.json b/package.json index d56b46b18..953ae3201 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "node-slack-sdk", "devDependencies": { - "eslint": "^7.32.0", - "eslint-plugin-jsdoc": "^30.6.1" + "eslint": "^8.47.0", + "eslint-plugin-jsdoc": "^46.5.0" } }