Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar buttons don't have accessible names #3172

Closed
edjw opened this issue Sep 12, 2020 · 1 comment
Closed

Toolbar buttons don't have accessible names #3172

edjw opened this issue Sep 12, 2020 · 1 comment

Comments

@edjw
Copy link

edjw commented Sep 12, 2020

Please describe the a concise description and fill out the details below. It will help others efficiently understand your request and get to an answer instead of repeated back and forth. Providing a minimal, complete and verifiable example will further increase your chances that someone can help.

Steps for Reproduction

Run Lighthouse on any page with Quill on it

See that the page is marked down on accessibility because the toolbar buttons don't have text content or aria-label properties

Expected behavior:

Quill's toolbar buttons have aria-label properties

Actual behavior:

Quill's toolbar buttons don't have aria-label properties

Platforms:

n/a

Version:

1.3.7

@edjw
Copy link
Author

edjw commented Sep 12, 2020

I now see this is discussed in #2038 and #1173

@edjw edjw closed this as completed Sep 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant