Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes_{daemonset,deployment}: set automount_service_account_token to true #78

Closed
flokli opened this issue Feb 24, 2021 · 4 comments

Comments

@flokli
Copy link

flokli commented Feb 24, 2021

Contrary to the kubernetes defaults, the kubernetes terraform provider hardcodes automount_service_account_token to false:

hashicorp/terraform-provider-kubernetes#38

However, this leads to non-working resources being created, as they rely on that defaulting to true.

k2tf should add

automount_service_account_token = true
@meroupatate
Copy link

thank you @flokli i spent two days trying to figure out what was wrong with my deployment and my daemonset 😭

@flokli
Copy link
Author

flokli commented Apr 29, 2021

@meroupatate sorry to hear. If there really needs to be this deviation from the defaults, it should really be documented loudly…

@flokli
Copy link
Author

flokli commented May 14, 2021

It seems terraform-provider-kubernetes pedalled back, and switched over to use the k8s defaults again: hashicorp/terraform-provider-kubernetes#1054

@sl1pm4t
Copy link
Owner

sl1pm4t commented Oct 5, 2021

I think this is resolved upstream (as pointed out above by @flokli ), so going to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants