Skip to content
This repository has been archived by the owner on Apr 3, 2022. It is now read-only.

fix: revert regressions #18

Merged
merged 1 commit into from
Mar 27, 2021
Merged

fix: revert regressions #18

merged 1 commit into from
Mar 27, 2021

Conversation

kyranet
Copy link
Member

@kyranet kyranet commented Mar 27, 2021

Turns out, filters aren't available in v3.3 master yet, only in v3.4 dev.
This PR reverts some of the v4 updates, as the deprecated payloads are not longer deprecated as of recent commits.

@kyranet kyranet requested a review from favna as a code owner March 27, 2021 17:52
@kyranet kyranet added Meta: BugFix PRs that fix bugs or issues. Priority: Critical Issues that must be fixed or PRs that must be finished and merged with maximum priority. labels Mar 27, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 693325418

  • 40 of 50 (80.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.09%) to 75.363%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/core/Player.ts 18 28 64.29%
Files with Coverage Reduction New Missed Lines %
src/core/Player.ts 2 37.5%
Totals Coverage Status
Change from base Build 693139076: -0.09%
Covered Lines: 1500
Relevant Lines: 1992

💛 - Coveralls

@kyranet kyranet merged commit a3bf758 into main Mar 27, 2021
@kyranet kyranet deleted the fix/reverted-regressions branch March 27, 2021 18:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Meta: BugFix PRs that fix bugs or issues. Priority: Critical Issues that must be fixed or PRs that must be finished and merged with maximum priority.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants