Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid VPN authentication handled incorrectly #783

Closed
Senyoret1 opened this issue May 31, 2021 · 2 comments
Closed

Invalid VPN authentication handled incorrectly #783

Senyoret1 opened this issue May 31, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@Senyoret1
Copy link
Contributor

Describe the bug
The vpn client app is not connecting. I ran 2 visors in different virtual machines, using the last changes of the develop branch. When starting the vpn client app of the first visor to connect to the vpn server app of the second visor, the connection is never stablished. A few seconds after starting the app, the client and server apps show this in the console: Error during close route group: close route group timed out: context deadline exceeded . Eventually, the visor running the client app panics.

After that, the calls to the GET /api/visors/{pk} API endpoint return Connection failed, reconnecting in the detailed_status property of the vpn client app until the visor is stopped. A problem with this is that, at the same time, the status property returns 0, which the UI interprets as the app being stoped, so the button for stopping the vpn is not shown. Maybe it does not make much sense to report that the app is stopped with the status property set to 0 and at the same time report that it is reconnecting with the detailed_status property set to Connection failed, reconnecting, but if there is a technical reason for that, maybe the UI can be adapted for considering the special case,

@Senyoret1 Senyoret1 added the bug Something isn't working label May 31, 2021
@Senyoret1
Copy link
Contributor Author

I checked again and this happens when using an incorrect password for connecting with the vpn server. This means the app works, but the way it is reacting to incorrect passwords is very inadequate. Maybe the client should stop trying after some time.

@jdknives
Copy link
Member

@Senyoret1 in that case I will rename the ticket. Will fix it.

@jdknives jdknives changed the title The VPN is not working well Invalid VPN authentication handled incorrectly Sep 27, 2021
@ersonp ersonp mentioned this issue Sep 30, 2021
@jdknives jdknives closed this as completed Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants