Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review snet implementation #760

Closed
jdknives opened this issue May 7, 2021 · 1 comment
Closed

Review snet implementation #760

jdknives opened this issue May 7, 2021 · 1 comment
Assignees

Comments

@jdknives
Copy link
Member

jdknives commented May 7, 2021

Describe the feature

While reviewing #724 it was discovered that a lot of modules depend on snet module for working, which may indicate the module implementation could be improved. We should review the implementation and check if we can decouple snet from other modules a bit more.

@jdknives
Copy link
Member Author

jdknives commented May 7, 2021

This has two reasons:

  1. snet was initially just a small wrapper and now seems to be required for most modules to start which decreases startup performance
  2. it makes development more complex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants