Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy Pubkey button #388

Closed
4rchim3d3s opened this issue Jun 3, 2020 · 5 comments
Closed

Copy Pubkey button #388

4rchim3d3s opened this issue Jun 3, 2020 · 5 comments
Labels

Comments

@4rchim3d3s
Copy link
Contributor

4rchim3d3s commented Jun 3, 2020

Feature description

It would be nice to have a copy paste button like inside the visor details when seeing hypervisor list.

Is your feature request related to a problem? Please describe.
When I try to mark and copy the pubkey in the visor list I get directed to the visor instead of just marking the pubkey.

@jdknives
Copy link
Member

jdknives commented Jun 3, 2020

@4rchim3d3s you would want a copy button here?
Bildschirmfoto 2020-06-03 um 11 04 14

@jdknives jdknives changed the title hypervisor button for copy paste pubkey in visor list Copy Pubkey button Jun 3, 2020
@4rchim3d3s
Copy link
Contributor Author

Yes, like this for example (with better coloring, just copied from visor):

image

Also the labeling is lost everytime hypervisor gets restarted, but I think this is a known issue

@jdknives
Copy link
Member

jdknives commented Jun 3, 2020

@4rchim3d3s Copy. Thats not a know issue actually. I have not encountered it so far. Will try to reproduce it.

@4rchim3d3s
Copy link
Contributor Author

4rchim3d3s commented Jun 3, 2020

Just had a deeper look into it.
The label gets lost the moment i close my firefox tab and go to localhost:8000 again.
I use Firefox in privacy mode.
Tried with google chrome and there it works, so the labeling is saved inside cookies or something like that?

Maybe would be helpful to save the labeling inside the visor, when using two different hypervisors you have to label every visor again. On the other hand maybe you want to label it different on the two hypervisors. How about a custom label / hypervisor label (saved in hypervisor and unique to this hypervisor) and a visor label (saved on visor and therefore the same on two different hypervisors)?

So you would have to have two label columns inside the visor list

@jdknives
Copy link
Member

jdknives commented Jun 3, 2020

@4rchim3d3s that explains it. Will think about something like that. Not sure whether it makes a lot of sense to have different label types or store labels on visors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants