Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to prepare for Scala Steward #49

Closed
RomanLebid opened this issue Sep 6, 2021 · 1 comment
Closed

Update dependencies to prepare for Scala Steward #49

RomanLebid opened this issue Sep 6, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@RomanLebid
Copy link
Contributor

Currently more and more teams now have Scala Steward enabled for their repos. Unfortunately, that combination can sometimes prevent engineers from upgrading, as some library maintainers don't pay enough attention to binary compatibility.

That situation can be improved now that eviction warnings have become eviction errors and it's much easier to find out about any possible issues at compile time.

Proposed solution is to enable scala-steward for kafka-topic-loader repository, so that teams can all align on the same versions of these dependencies by keeping them up to date.

kafka-topic-loader has quite a few libraries in use, so to avoid a deluge of PRs coming in all at once, it would be easier to update most of them:

  • refined and pureconfig as they are the most notorious to break binary compatibility
  • akka does not allow mixed versioning and you need to explicitly provide all your deps with with the version in use
java.lang.IllegalStateException: You are using version 2.6.15 of Akka, but it appears you (perhaps indirectly) 
also depend on older versions of related artifacts. You can solve this by adding an explicit dependency 
on version 2.6.15 of the [akka-discovery] artifacts to your project.
@paulaylingdev paulaylingdev added the enhancement New feature or request label Jan 17, 2022
@paulaylingdev
Copy link
Contributor

Scala steward has been added, dependencies are now being updated.

The following seem to satisfy this issue:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants