Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skupper update does not re-write secrets #791

Closed
ted-ross opened this issue Jun 14, 2022 · 2 comments · Fixed by #1253
Closed

Skupper update does not re-write secrets #791

ted-ross opened this issue Jun 14, 2022 · 2 comments · Fixed by #1253
Assignees
@nluaces
Labels
bug Something isn't working

Comments

@ted-ross
Copy link
Member

I picked up version 1.0.2 so I could use the fix to #785. Running skupper update was successful in updating the router and the service controller, but the secrets (specifically skupper-local-client) were not re-generated. Therefore, the bug in 1.0.1 remained in effect after the update to 1.0.2.
@ted-ross ted-ross added the bug Something isn't working label Jun 14, 2022
@ted-ross
Copy link
Member Author

In general, if a bug is fixed that results in a changed artifact (secret, etc.), the update operation should regenerate the affected artifacts or throw an error saying the user needs to delete and re-init the site.

@nluaces
Copy link
Member

nluaces commented Jun 14, 2022

The skupper updatecommand is rewriting secrets only for versions less recent than skupper 0.5.0.

@nluaces nluaces self-assigned this Jul 12, 2022
@nluaces nluaces mentioned this issue Oct 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nluaces nluaces

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update resources for older versions than 1.0.2 nluaces/skupper
2 participants
@ted-ross @nluaces