Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tokens created with type cert have a static name #1154

Closed
fgiorgetti opened this issue Jun 27, 2023 · 2 comments · May be fixed by #1256
Closed

Tokens created with type cert have a static name #1154

fgiorgetti opened this issue Jun 27, 2023 · 2 comments · May be fixed by #1256
Labels
enhancement New feature or request

Comments

@fgiorgetti
Copy link
Member

If a token is created using skupper token create --token-type cert my-token.yaml,
skupper is setting the Secret name to skupper. With that if you generate multiple
secrets, for different clusters, and apply them all to a given namespace, only one link
will be defined, as secret skupper will be replaced.

It would be good to use a distinct secret name, probably based on the site-id.
@fgiorgetti fgiorgetti added the enhancement New feature or request label Jun 27, 2023
@DendoD96 DendoD96 mentioned this issue Nov 2, 2023
Open
@grs
Copy link
Member

grs commented Nov 3, 2023

Note that there is a --name option that can be used to override the default. That said I would accept the current choice of default is not necessarily optimal.

@fgiorgetti
Copy link
Member Author

Closing as the --name flag seems to take care of it.
@DendoD96 please let us know if you have any concern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Name of cert token based on site UID DendoD96/skupper
2 participants
@grs @fgiorgetti