Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the default ingress and ingress-hosts values for podman sites #1185

Closed
fgiorgetti opened this issue Jul 20, 2023 · 3 comments
Closed
Labels
enhancement New feature or request

Comments

@fgiorgetti
Copy link
Member

On podman sites, the default ingress is host, which requires --ingress-host to be provided.
This gives a bad user expirence, as it differs from kubernetes sites where you can simply use skupper init.

The suggestion is to switch the default ingress to none and also set the default --ingress-host (if none provided)
to the fully qualified hostname.

@fgiorgetti fgiorgetti added the enhancement New feature or request label Jul 20, 2023
@DendoD96
Copy link
Contributor

DendoD96 commented Sep 4, 2023

Hi @fgiorgetti,
Could you help me understand this statement?

From what I know, on podman sites, ingress option can be set to none | external, by default the option is set to ''.
In the first case skupper does not support linking to the current site and so --ingress-host is ignored, while in the other two cases --ingress-host is required. So, if we set ingress to none, why shoud we set the default ingress-host to the FQHN?

Best regards,
Daniele

@fgiorgetti
Copy link
Member Author

Hello @DendoD96 . The goal is actually to set a FQHN when the ingress is set to the default (external), so
that users can simply run a skupper init, without explicitly needing to provide an ingress-host.

Switching the default ingress value to none is not yet settled and it is something to be discussed still.

@fgiorgetti
Copy link
Member Author

Fixed by #1230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants