Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skupper cli is not enforcing --console-auth option #1149

Closed
bryonbaker opened this issue Jun 21, 2023 · 1 comment
Closed

skupper cli is not enforcing --console-auth option #1149

bryonbaker opened this issue Jun 21, 2023 · 1 comment
Assignees

Comments

@bryonbaker
Copy link

bryonbaker commented Jun 21, 2023

The skupper cli documentation states that --console-auth=internal is a mandatory switch if you specify either of the other options: --console-user or --console-password

However, the following command is accepted:
'skupper init --enable-console --enable-flow-collector --console-password password --console-user admin'
(This command is defaulting to internal)

The switch existence either needs to be enforced or update the documentation to state that the default is 'internal'.

Skupper version: 1.4.1
OCP version 12.4.5

@pwright
Copy link
Member

pwright commented Jul 6, 2023

@bryonbaker I'm not seeing where it says --console-auth=internal is a mandatory switch if ....

What i do see is Valid only when --console-auth=internal and I think that's the correct phrase, is there somewhere else you saw 'mandatory'? Should we change to Valid only when --console-auth=internal (default) to avoid folks tripping on this?

@nluaces nluaces closed this as completed Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants