Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allowedOutgoingLinksHostnames: claim vs router+edge #89

Open
hash-d opened this issue May 10, 2022 · 2 comments
Open

allowedOutgoingLinksHostnames: claim vs router+edge #89

hash-d opened this issue May 10, 2022 · 2 comments

Comments

@hash-d
Copy link
Member

hash-d commented May 10, 2022

When creating a link using a claim token (as opposed to a cert token), Skupper will first connect to the claim service, and then configure the link to the router (inter-router and possibly edge router).

The claim service and the two routers may be running on different hostnames, depending the Kubernetes distribution and other factors. If that is the case, and the policy is receiving full hostnames, then both hostnames must be listed on the policy.

  • If the claim hostname is not listed, the link creation will fail immediately with Error: Failed to create link: outgoing link to claims-namespace.domain is not allowed
  • However, if only the claim hostname is listed, the link creation will succeed, but the link will not come up (as the policy engine sees no authorization to connect to the router host)

Similarly, when removing policies, both hostnames need removed: if only the claims hostname is removed, new links will be disallowed, but the existing links will be unaffected.

This should not be an issue when the hostnames are actually regexes that accept any FQDN within a given domain.

The documentation currently does not mention this detail. Please consider whether it should be added to the documentation.

@fgiorgetti to comment.

@hash-d hash-d changed the title allowedOutgoingLinksHostnames: claim vs router allowedOutgoingLinksHostnames: claim vs router+edge May 13, 2022
@hash-d
Copy link
Member Author

hash-d commented May 13, 2022

I have edited the issue title and description to reflect the information from skupperproject/skupper#762. Adding only the inter-router host may not be enough for allowing the links.

@pwright
Copy link
Member

pwright commented Jun 9, 2022

@fgiorgetti Do we need to address this issue soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants