Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Add a plot_topics method to GapEncoder #1124

Open
Vincent-Maladiere opened this issue Oct 22, 2024 · 6 comments
Open

[FEAT] Add a plot_topics method to GapEncoder #1124

Vincent-Maladiere opened this issue Oct 22, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@Vincent-Maladiere
Copy link
Member

Problem Description

One of the GapEncoder 's main features is its interpretability. The documentation shows how to plot a heatmap representing activations across topics and their content, but getting this representation right is time-consuming.

Feature Description

I suggest we bring this method directly into the GapEncoder class.

Alternative Solutions

Creating a separate function elsewhere, akin to sklearn.tree.plot_tree, but at the cost of being less practical and visible.

Additional Context

No response

@Vincent-Maladiere Vincent-Maladiere added the enhancement New feature or request label Oct 22, 2024
@Vincent-Maladiere Vincent-Maladiere changed the title [Feat] Add a plot_topics method to GapEncoder [FEAT] Add a plot_topics method to GapEncoder Oct 22, 2024
@jeromedockes
Copy link
Member

I agree this would be useful; see also #909 (comment)

@GaelVaroquaux
Copy link
Member

GaelVaroquaux commented Oct 22, 2024 via email

@Vincent-Maladiere
Copy link
Member Author

But can we have a generic methods (ie get_report()), which could be used everywhere in skrub?

Can you elaborate a bit on this @GaelVaroquaux? Do you see get_report also working for TextEncoder and MinHashEncoder?

@GaelVaroquaux
Copy link
Member

GaelVaroquaux commented Oct 22, 2024 via email

@Vincent-Maladiere
Copy link
Member Author

Very interesting! Could we list somewhere the kind of visualizations we would like to see for some objects?

@jeromedockes
Copy link
Member

jeromedockes commented Oct 22, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

3 participants