Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's missing in the query implementation? #2

Open
lexum0 opened this issue Nov 18, 2024 · 4 comments
Open

What's missing in the query implementation? #2

lexum0 opened this issue Nov 18, 2024 · 4 comments

Comments

@lexum0
Copy link

lexum0 commented Nov 18, 2024

The query code has some incomplete code commented out but I haven't been able to make it work nor understand how the builder works

What's the logic to decode the queries data?

@marcprux
Copy link
Contributor

The beginnings of PostgrestFilterBuilder are in place, but they haven't been tested or otherwise exercised. The general goal would be to get the SkipSupabaseTests passing a test that uses a query with the same API that the Swift Supabase uses. This is a bit tricky since the Kotlin implementation (io.github.jan.supabase.postgrest.query) is a third-party contribution and doesn't match the Swift API, and so creating a Swift-compatible facade that maps the Swift functionality to the Kotlin version is a challenge.

@lexum0
Copy link
Author

lexum0 commented Nov 18, 2024

Do you know how to map the missing functionality?

@marcprux
Copy link
Contributor

That's what needs implementation.

I would recommend checking out the https://github.com/skiptools/skip-supabase.git repository directly and running the SkipSupabase tests, and then trying to implement a simple query in one of the test cases.

@lexum0
Copy link
Author

lexum0 commented Nov 18, 2024

I have read the full code and made several attempts. Nothing works, and the exceptions raised in Kotlin / logcat don't say much, but the data decoding seems to be the problem.

I know that's what's missing, do you know how to implement it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants