Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace class checks #20

Closed
mhesselbarth opened this issue Sep 21, 2022 · 1 comment
Closed

Replace class checks #20

mhesselbarth opened this issue Sep 21, 2022 · 1 comment

Comments

@mhesselbarth
Copy link

Regarding openjournals/joss-reviews#4771

Use inherits() instead of if (class(x) == <CLASS>
@skiptoniam
Copy link
Owner

I have updated this - I used a mix of inherits and isa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@skiptoniam @mhesselbarth