Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge with ppmFit #18

Closed
mhesselbarth opened this issue Sep 21, 2022 · 1 comment
Closed

Merge with ppmFit #18

mhesselbarth opened this issue Sep 21, 2022 · 1 comment

Comments

@mhesselbarth
Copy link

Regarding openjournals/joss-reviews#4771

Maybe it makes sense to merge the ppmData and ppmFit package into one package. I think the merged package would not be too big to successfully maintain and the functionality seems to be extremely related.

However, I also understand that there might be reasons to keep the packages separated. Thus, this suggestion could also be ignored by the authors with some reasoning.

@skiptoniam
Copy link
Owner

At the moment, ppmFit is a fair way off being ready. And there are some methods still being worked up for this package - which might end up in other manuscripts. I do think this is a good idea in the long run. But I won't address if for this review openjournals/joss-reviews#4771. I will close this issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants