Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the name of the button(s) #7

Closed
sinsukehlab opened this issue Jun 15, 2022 · 1 comment · Fixed by #8
Closed

Correct the name of the button(s) #7

sinsukehlab opened this issue Jun 15, 2022 · 1 comment · Fixed by #8

Comments

@sinsukehlab
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The instruction for ⌨️ Activity: Suggest changes says, "After the commment form appears, click the Insert a suggestion button," but I found an Add a suggestion button instead of an Insert a suggestion one. Also, the button described on the last line actually says "Add single comment".

Describe the solution you'd like
The instruction should be modified so that it can mean the correct buttons.

  • Insert a suggestionAdd a suggestion
  • (Add a single commentAdd single comment)

Describe alternatives you've considered
The Add single comment button should be changed into an Add a single comment one.

Additional context
The instructions for the Activity is as follows:

  1. On the pull request, click Files changed.
  2. Find the index.html changes.
  3. Hover your cursor next to the line numbers on the left side of the page.
  4. Click the blue plus icon.
  5. After the commment form appears, click the Insert a suggestion button.
  6. Edit the suggestion.
  7. Click Add a single comment.
@sinsukehlab
Copy link
Contributor Author

This discussion might be related to my issue.

Discussed in https://github.com/orgs/skills/discussions/9

Originally posted by BecAndCall June 15, 2022
Hello, Skills team.

Everything went pretty smoothly, overall, but I did not see the "Insert a suggestion button" in Step 3. This may be why I did not see the "Commit suggestion" option in Step 4.

Can anyone screen shot or advise what I missed? I'd appreciate it. I'll walk through again until I get this right. 👍

Cheers, Bec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant