Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix essential parsing. #8

Open
2 of 4 tasks
skewballfox opened this issue Jul 2, 2021 · 1 comment
Open
2 of 4 tasks

fix essential parsing. #8

skewballfox opened this issue Jul 2, 2021 · 1 comment
Labels
bug Something isn't working parsing bug or enhancement related to parsing and rebuilding snippets

Comments

@skewballfox
Copy link
Owner

skewballfox commented Jul 2, 2021

In order to have snippets composed of snippets, without adding anything else, it is necessary to parse tabstops and subsnippets, and store their correct locations.

Since this is a rather vague problem, composed of a lot of smaller but related specific problems, it's probably best to just make this into a list of issues.

here are the problems right now:

  • need to append \n to the end of end text sections, OR need to change how snippets are stored so that they are a single string rather than a vector of strings
  • need to handle component creation directly from the parser
  • need to actually handle variables/Functors
  • need to handle the transforms of variables

this list will be updated as I make progress or discover new issues.

@skewballfox skewballfox added parsing bug or enhancement related to parsing and rebuilding snippets bug Something isn't working labels Jul 2, 2021
@skewballfox
Copy link
Owner Author

The latest commit fixed the missing newlines by changing how snippets are stored. Since add_target and drop_target return nothing to the caller, it makes sense to move more work to that step when possible. also since the only time the dashmap containing the snippets needs to be accessed is when processing a get_snippet request, now it only contains the content, and all other relevant information to a snippet has been moved into SnippetSet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working parsing bug or enhancement related to parsing and rebuilding snippets
Projects
None yet
Development

No branches or pull requests

1 participant