Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the repo a bit cleaner by subdividing things in folders, so adding some more referenced docs outside readme #12

Open
Tracked by #11
sjaehn opened this issue Apr 7, 2023 · 10 comments
Labels
enhancement New feature or request

Comments

@sjaehn
Copy link
Owner

sjaehn commented Apr 7, 2023

|examples
| |
myAmp...
|docs
| |
License-options.md
| |_ Build-systems-cmake-makefile-meson.md
| |_ UI-adding-resources.md
| |_ ...
|README.md
|
...

Issued by @redtide

@sjaehn sjaehn mentioned this issue Apr 7, 2023
10 tasks
@sjaehn sjaehn added the enhancement New feature or request label Apr 7, 2023
@redtide
Copy link
Collaborator

redtide commented Apr 19, 2023

About this: I'm currently trying to port my sites from jekyll (ruby and liquid, IIRC originally made by and for GitHub) to mkdocs (python and jinja2); these are static website generators.
The latter is simple to setup and at the minimum requires only a yaml file in the root dir. I'll make a test site as demo.
This way the files can be read in the repo and also on a site.

@redtide
Copy link
Collaborator

redtide commented Apr 20, 2023

in repo: https://github.com/redtide/lv2tutorial/tree/mkdocs/docs
the site demo: https://redtide.github.io/lv2tutorial/

EDIT: just noticed now that the license on my fork is still gpl3 though the fork is up to date with the upstream master and ahead of 1 commit, how is it possible??

@sjaehn
Copy link
Owner Author

sjaehn commented Apr 29, 2023

Thanks for your work. Please make a pull request. Then I can merge it.

@redtide
Copy link
Collaborator

redtide commented Apr 29, 2023

it's more a draft because it's a very big change, I think should be discussed:
I splitted the readme in several documents to display as website pages, that means that the readme should be re-made to have references to those files, otherwise we should maintain 2 versions of the docs

@sjaehn
Copy link
Owner Author

sjaehn commented Apr 29, 2023

It's not a big thing (my POV). README.md as an entry point. With an index linking to the respective *.md files in the ./docs folder. This makes sense as the tutorial gets bigger and bigger.
I can do the changes as well (or at least the index - let me know), but you already did the most of the work.

@redtide
Copy link
Collaborator

redtide commented Apr 29, 2023

if you are OK with it then I can handle the readme as well, not much things there, I have also some other (tiny) additions for it. I think i'll do the PR tomorrow

@redtide
Copy link
Collaborator

redtide commented Apr 30, 2023

I have the thing ready, I only miss a cmake file for the bwidgets example.
Before proceeding I need to talk to you about the CI build for the site and some rules needed to make the job straightforward. Email? (I'm redtid3 at gmail dot com), IRC? (lad channel to say one)

@redtide
Copy link
Collaborator

redtide commented May 2, 2023

OK, so now it's missing the examples directory where to move the plugins, with a related cmake files reorganization, so I will take the chance to add also the missing cmake files for the latest plugins. If it's OK I'll do it this weekend.

@redtide
Copy link
Collaborator

redtide commented May 7, 2023

before doing anything, could be moving the plugins in a "examples" dir being confusing for users after seeing videos?

@sjaehn
Copy link
Owner Author

sjaehn commented May 8, 2023

I also thought about this issue. And yes, it could be confusing for the viewers if they can't directly find the source code folders (as in the videos). On one hand it should be doable for the viewers to find the content inside an "examples" or "src" folder. But on the other hand there's no need to add such a stumbling block.

My POV: It's better to keep the source code file locations. And I think clean enough as all source code folders start with "my". (Notable exception: LV2Stub. This one can also be renamed to "templates" or whatever (as I don't think that I had mentioned this folder in one of my videos (?)). And I should take hands on its content.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants