Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop x/crypto package dependency #932

Merged
merged 4 commits into from
Mar 28, 2019
Merged

Drop x/crypto package dependency #932

merged 4 commits into from
Mar 28, 2019

Conversation

tandr
Copy link
Contributor

@tandr tandr commented Mar 26, 2019

Closes #928

@tandr tandr marked this pull request as ready for review March 26, 2019 20:57
@tandr tandr mentioned this pull request Mar 26, 2019
Closed
lavoiesl
lavoiesl approved these changes Mar 27, 2019
View reviewed changes
Copy link
Collaborator

@lavoiesl lavoiesl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful

internal/terminal/terminal_check_bsd.go Outdated Show resolved Hide resolved
internal/terminal/terminal_check_unix.go Outdated Show resolved Hide resolved
@tandr
Copy link
Contributor Author

tandr commented Mar 27, 2019

Would it be possible to slap a tag on it once it is merged in? Or it is not sufficiently big change to bump it to v1.4.1 ?

@lavoiesl
Copy link
Collaborator

A patch bump would be in order, yes. I’m just waiting for someone else to review.

@dgsb
Copy link
Collaborator

dgsb commented Mar 28, 2019

@tandr that looks good to me.

@dgsb dgsb merged commit 787e519 into sirupsen:master Mar 28, 2019
@tandr tandr deleted the drop-crypto-2 branch March 28, 2019 09:06
@tandr
Copy link
Contributor Author

tandr commented Mar 28, 2019

@dgsb David, would you be able to tell when do you guys expect v1.4.1 get tagged? Reason I am asking is that or I need to pull it now and then second time when you tag it, or if you expect it tomorrow or in very near future, I can just wait for it instead.

@thaJeztah thaJeztah mentioned this pull request Mar 28, 2019
Merged
@thaJeztah
Copy link
Collaborator

+1 on tagging a v1.4.1 for this 🤗

@dgsb
Copy link
Collaborator

dgsb commented Apr 1, 2019

@tandr and @thaJeztah we can not yet, we do not want to make public the new terminal interface.

@tandr
Copy link
Contributor Author

tandr commented Apr 1, 2019 •
edited
Loading

@dgsb added #943 to address this

@dependabot dependabot bot mentioned this pull request Mar 11, 2021
Closed
cgxxv pushed a commit to cgxxv/logrus that referenced this pull request Mar 25, 2022
@dgsb
Merge pull request sirupsen#932 from tandr/drop-crypto-2
b959081 
Drop x/crypto package dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavoiesl lavoiesl lavoiesl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tandr @lavoiesl @dgsb @thaJeztah